fix: allow Enter on public share Download link#62367
Open
kristian-zendato wants to merge 1 commit into
Open
Conversation
kristian-zendato
requested review from
nfebe and
sorbaugh
and removed request for
a team
July 21, 2026 14:01
Contributor
|
/backport to stable34 |
Contributor
|
/backport to stable33 |
susnux
approved these changes
Jul 21, 2026
susnux
left a comment
Contributor
There was a problem hiding this comment.
looks good, but ESLint needs to be resolved
kristian-zendato
force-pushed
the
fix/public-download-button-focus
branch
4 times, most recently
from
July 21, 2026 15:30
7febb0c to
aa61dbf
Compare
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/public-download-button-focus
branch
from
July 21, 2026 15:49
aa61dbf to
769773c
Compare
sorbaugh
approved these changes
Jul 21, 2026
skjnldsv
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On public shares, the header Download control is an
<a>that can be focused with the keyboard, but Enter did not start the download.Cause: each
FileEntryregistered an Enter hotkey withprevent: true/stop: true.useHotKeyalways calledpreventDefaultbefore the callback, so Enter was cancelled even when the row was inactive and did nothing.Change: only call
preventDefault/stopPropagationinsidetriggerDefaultActionwhen the row is active. Browser default activation of the Download link works again.Added a Cypress regression test that focuses Download and presses Enter.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)